Increase PS/2 timeouts for reset #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chosen arbitrary timeout value works in qemu, but causes a panic on boot on a Dell Optiplex 9020. I've tried a few values and with these, it boots with a Cherry and a HP keyboard and two Logitech mice.
kevinaboos
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Thanks very much! Appreciate the report of experiences on real hardware.
Theseus "shouldn't" require a mouse to exist in order to boot, at least it didn't used to. We should also be able to select the correct scan code set by querying the PS2 controller, but I suppose were not actually doing that correctly. We'd happily accept that change too, if you're so inclined. 😊
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
The previous arbitrary timeout value works in QEMU, but does not work on a Dell Optiplex 9020. With the new higher timeout values, Theseus successfully boots with a Cherry and a HP keyboard and two Logitech mice, though the devices still do not seem to function correctly. f2fe78a
|
@YtvwlD you could try to go through several Theseus/kernel/keyboard/src/lib.rs Line 49 in ffb5e8b iirc another problem was that rn we only have keycodes defined for set 1: Theseus/libs/keycodes_ascii/src/lib.rs Line 137 in ffb5e8b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chosen arbitrary timeout value works in qemu, but causes a panic on boot on a Dell Optiplex 9020. I've tried a few values and with these, it boots with a Cherry and a HP keyboard and two Logitech mice.
I also had to change the
ScancodeSettoSet2for the Cherry keyboard, but that's not in this PR. With these changes, Theseus boots on the Optiplex. I still can't input text or move the mouse.Also, I think it would be nice if booting didn't require a mouse.