Handle paths with multiple components in chdir
#1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for changing multiple levels of directories at once e.g. `cd task/2`. Also since `components` normalizes the trailing slash, this fixes the bug which prevented changing into a directory followed by a trailing slash e.g. `cd namespaces/`. This is indicative of the larger issue that each `FsNode` implementation needs its own path parsing algorithm e.g. `cd task && cd ..` doesn't work because `TaskFs` doesn't support `..`. I'll have a PR ready soon to fix that issue. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
tsoutsman
force-pushed
the
recursively-apply-cd
branch
from
37060d6
to
6fd531f
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Adds support for changing multiple levels of directories at once, e.g., `cd ./task/2`. * Also, since `components()` normalizes the trailing slash, this fixes the bug which prevented changing into a directory followed by a trailing slash, e.g., `cd namespaces/`. * This is indicative of the larger issue that each `FsNode` implementation needs its own path parsing algorithm. For example, the command `cd task && cd ..` does not work because `TaskFs` doesn't support the notion of a parent directory (`..`). A fix for this is coming soon. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com> 3a678a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for changing multiple levels of directories at once e.g.
cd task/2.Also since
componentsnormalizes the trailing slash, this fixes the bug which prevented changing into a directory followed by a trailing slash e.g.cd namespaces/.This is indicative of the larger issue that each
FsNodeimplementation needs its own path parsing algorithm e.g.cd task && cd ..doesn't work becauseTaskFsdoesn't support... I'll have a PR ready soon to fix that issue.