Don't hardcode the path for bash #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems (eg. NixOS) don't have it in /bin.
|
Ah, good point! Do all systems have |
|
Most of them apparently? I failed to find an authoritative source (this is the best I could come up with), but most modern systems seem to have it either in |
|
Cool, I also looked into it and it seems that using env is okay, especially in this scenario because bash wouldn't suffer from different versioning issues like python and other interpreters might. |
github-actions bot
pushed a commit
to tsoutsman/Theseus
that referenced
this pull request
Dec 27, 2023
Some systems (e.g., NixOS) don't have `/bin/bash`, so use the `env` utility to locate `bash` instead. 813015b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems (eg. NixOS) don't have it in /bin.