Subgraph: Exposing data to populate Activity Details for stake operation #330
Conversation
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ioay
force-pushed
the
subgraph_activity_details
branch
4 times, most recently
from
49d7f36 to
79ffcbd
Compare
ioay
force-pushed
the
subgraph_activity_details
branch
5 times, most recently
from
a1df225 to
fbfc805
Compare
ioay
force-pushed
the
subgraph_activity_details
branch
from
fbfc805 to
8d44058
Compare
subgraph/subgraph.yaml
Outdated
| indexerHints: | ||
| prune: auto |
There was a problem hiding this comment.
Why did we remove it? Should we keep it or is it unnecessary?
There was a problem hiding this comment.
Because indexerHints are not supported prior to 1.0.0. It's throwing an error while deploying locally:
Failed to deploy to Graph node http://localhost:8020/: subgraph resolve error: resolve error: indexerHints are not supported prior to 1.0.0.
We can leave it, but we need to increase the specVersion prop to min. ver: 1.0.0: 742d770
There was a problem hiding this comment.
Maybe we should set specVersion to the latest to support all features? Ofc non-blocking, just wondering.
ioay
force-pushed
the
subgraph_activity_details
branch
from
f8dd76c to
7a58df6
Compare
ioay
force-pushed
the
subgraph_activity_details
branch
from
1ab8386 to
497cdae
Compare
| test("Deposit entity should exist", () => { | ||
| assert.entityCount("Deposit", 1) | ||
| }) |
There was a problem hiding this comment.
Can we test a case when the Deposit entity doesn't exist ?
There was a problem hiding this comment.
Why can't we throw an error as we did before? We can test expected errors in subgraph https://thegraph.com/docs/en/developing/unit-testing-framework/#expected-failure.
Throw an error when the Deposit entity deosn't exist. We throw an error just to improve readability of the code. This should never happen because the graph indexes events chronologically and the deposit can only be finalized once it has been initialized. This case is possible when we set the wrong `startBlock` in manifest but we always set the `startBlock` to block where a given contract was deployed. Cover this case in unit tests.
We changed the type of the `referral` field to `Int` in 8197d98 so just for consistency we update it in tests as well.
Subgraph: Activity Details for deposit operation
What was done
handleDepositInitializedeventhandleDepositFinalizedeventDepositOwner,Deposit,Withdraw,Event] & interfaceActivityDataPreview
Additional info
DEVELOPMENT QUERY URL - LATEST VERSION:
https://api.studio.thegraph.com/query/69074/a-test/version/latest