mtl: remove pin description from extended module config #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended module config such as pin description is not used by driver, let's remove them, lest anyone waste time on the don't care values when adding a new module. Signed-off-by: Yong Zhi <yong.zhi@intel.com>
lgirdwood
reviewed
Sep 8, 2023
There was a problem hiding this comment.
@mwasko @marcinszkudlinski will this be needed in the future ?
|
We need at least number of pins for each module. now formats and pins are verified when pipeline starts (module_prepare), which may be a little too late. Bind IPC should not be accepted if connecting not compatible modules or not existing pins - based on info from the manifest. So yes, those may become useful really soon. |
|
Thanks for the info, I somehow got the impression that Extended Manifest ("$AE1" ) is not used by FW. |
|
@yongzhi1 I will close this now. It can be re-opende later if direction changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended module config such as pin description is not used by driver, let's remove them, lest anyone waste time on the don't care values when adding a new module.