.github/ actions: replace travis #49
Conversation
|
WIP, just figured i would share as an FYI |
very likely, this was a copy paste refactor when I was doing the cppcheck work and haven't touched it in a few weeks, looking to land it soon. |
cujomalainey
force-pushed
the
travis
branch
3 times, most recently
from
16e4ea3
to
66b9025
Compare
cujomalainey
force-pushed
the
travis
branch
from
66b9025
to
cf5be35
Compare
|
@marc-hb feel free to ignore pushes till i mark ready for review, just running tests |
cujomalainey
force-pushed
the
travis
branch
15 times, most recently
from
d891bdd
to
e962a2e
Compare
|
@marc-hb i am at a loss for why checkpatch is not working properly, locally when i run the same command it performs the check on only my patch as expected, but in CI it seems to check the whole repo, any guesses what is going on? |
cujomalainey
force-pushed
the
travis
branch
4 times, most recently
from
501822a
to
c0343df
Compare
|
@cujomalainey @marc-hb any resolution here ? |
|
I have AIs, I just need to find time to do them |
|
@cujomalainey , if you still don't have the time, maybe @aborisovich could take over? It looks like https://github.com/actions/virtual-environments offers some Windows environments too. |
|
@marc-hb works for me, we had a re-org right after I started this and I have not had as much time to work upstream as I have wanted since then. |
|
@marc-hb I am starting next week work related to IPC/IDC Zephyr API usage and concept of a refactored build system that would allow seamlessly build SOF+Zephyr on both Linux and Windows for some platforms will be unfinished. I'm drowning in work for now. |
|
I understand, thx. On the other hand, I found Github Actions the best to test build system changes. |
|
Eh, 12months later and it still rebases cleanly. Apologies for abandoning this |
| steps: | ||
| - uses: actions/checkout@v2 | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} |
There was a problem hiding this comment.
Correct: by default checkout gives pull/12355/merge which is what most people want by default (even when they don't have a clue).
BTW: https://github.com/thesofproject/sof/blob/main/.github/workflows/codestyle.yml
|
@cujomalainey good to target for v2.5 ? |
|
Can't make any promises, this is pretty low on my priority list unfortunately |
cujomalainey
force-pushed
the
travis
branch
4 times, most recently
from
926ce92
to
2d5f0de
Compare
We removed them from the main repo, lets remove them here too. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
|
@marc-hb @lgirdwood all green, I think this is FINALLY ready to go. Then we can remove any travis hooks left. |
We removed them from the main repo, lets remove them here too.
Signed-off-by: Curtis Malainey cujomalainey@chromium.org