rimage: mtl: Use DP scheduler for AEC module #8419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongzhi1
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
|
Replace thesofproject/rimage#188, thanks!! |
| @@ -601,9 +601,10 @@ count = 27 | |||
| [[module.entry]] | |||
| name = "RTC_AEC" | |||
There was a problem hiding this comment.
Just for my knowledge: what is RTC_AEC?
Thanks
There was a problem hiding this comment.
Google webRTC Acoustic Echo Cancellation
There was a problem hiding this comment.
So, SOF, integrates webrtc library to do AEC?
This is a free library compiled for Xtensa DSP?
From this link, it seems so: https://webrtc.googlesource.com/src/
kv2019i
approved these changes
Oct 30, 2023
| @@ -601,9 +601,10 @@ count = 27 | |||
| [[module.entry]] | |||
| name = "RTC_AEC" | |||
| uuid = "B780A0A6-269F-466F-B477-23DFA05AF758" | |||
| affinity_mask = "0x3" | |||
| # bit #i = 1 means core #i is allowed. | |||
There was a problem hiding this comment.
I'd prefer a "rimage: mtl: " prefix for this commits.
There was a problem hiding this comment.
Ack, will update in next version.
yongzhi1
force-pushed
the
aec-dep-coreN
branch
from
c3bbd03
to
ec1ef94
Compare
yongzhi1
force-pushed
the
aec-dep-coreN
branch
from
ec1ef94
to
165e68f
Compare
Change domain_types to DP, and allow it to run all 3 cores. Signed-off-by: Yong Zhi <yong.zhi@intel.com>
yongzhi1
changed the title
lgirdwood
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change domain_types to DP, and allow it to run all 3 cores.