Audio: TDFB: Fix firmware crash caused by TDFB sink format set #9131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in tdfb_params() was incorrect for a component that can have different number of channels in source and sink. The update of sink format can it worst case crash the successive component in pipeline if the source channels count has changed from the value the component has been initialized for. The channels count need to be retrieved from input and output pins information in extended IPC4 base config. To get the extension the rimage toml files need to add for TDFB component the line init_config = "1". Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
lyakh
approved these changes
May 21, 2024
lgirdwood
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in tdfb_params() was incorrect for a component that can have different number of channels in source and sink. The update of sink format can it worst case crash the successive component in pipeline if the source channels count has changed from the value the component has been initialized for.
The channels count need to be retrieved from input and output pins information in extended IPC4 base config. To get the extension the rimage toml files need to add for TDFB component the line init_config = "1".