[DNM] dai: add support for Intel UAOL DAI #9227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlissows
requested review from
RanderWang,
abonislawski,
pblaszko,
marcinszkudlinski,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
lyakh
reviewed
Jun 17, 2024
plbossart
reviewed
Jun 17, 2024
| #else | ||
| channel = copier_cfg->gtw_cfg.node_id.f.v_index; | ||
| #endif | ||
| break; |
There was a problem hiding this comment.
I don't fully understand this.
for LNL+ all the DMA stuff is handled in the same way with an HDaudio-based solution.
We just moved some of the ALH stuff into the HDaudio prodessing - see line 94 the test for ALH.
so shouldn't the UAOL stuff also be moved under the HDAudio category? Why special case what looks identical?
tlissows
force-pushed
the
uaol-dai-upstream
branch
from
b89f3e5
to
f6551e3
Compare
tlissows
changed the title
plbossart
requested changes
Jul 19, 2024
| #else | ||
| channel = copier_cfg->gtw_cfg.node_id.f.v_index; | ||
| #endif | ||
| break; |
|
@tlissows ping ? |
Currently, the dai_set_config() function is called with copier gateway config data passed but without the config length, possibly making the config not parsable for some DAI drivers. This patch adds passing of the full ipc4_copier_gateway_cfg structure, giving DAI drivers the ability to access config length if needed. Signed-off-by: Tomasz Lissowski <tomasz.lissowski@intel.com>
Add strict use of dai_type enum items as a call parameter for dai_get_device() function. Currently, both the dai_type and sof_ipc_dai_type items are used inconsistently. Signed-off-by: Tomasz Lissowski <tomasz.lissowski@intel.com>
This adds support for Intel USB Audio Offload Link (UAOL) DAI. Signed-off-by: Tomasz Lissowski <tomasz.lissowski@intel.com>
tlissows
force-pushed
the
uaol-dai-upstream
branch
from
f6551e3
to
11bbbc5
Compare
|
Removed support for ACE1.x platform from this PR. Also aligned to the changes introduced by PR basefw: Add handling of IPC4_DMA_CONTROL messages. |
lgirdwood
reviewed
Oct 2, 2024
There was a problem hiding this comment.
@tlissows I assume still undergoing testing hence the DNM ? Pls also respond to open from @plbossart
| @@ -153,25 +154,25 @@ int dai_set_config(struct dai *dai, struct ipc_config_dai *common_config, | |||
| switch (common_config->type) { | |||
| case SOF_DAI_INTEL_SSP: | |||
| cfg.type = is_blob ? DAI_INTEL_SSP_NHLT : DAI_INTEL_SSP; | |||
| cfg_params = is_blob ? spec_config : &sof_cfg->ssp; | |||
| cfg_params = is_blob ? (void *)>w_cfg->config_data : &sof_cfg->ssp; | |||
There was a problem hiding this comment.
Do we need the void* cast here or is the compiler throwing up a warning in this case ? cfg_params is also const too.
|
|
||
| static void tlv_value_set_uaol_caps(struct sof_tlv *tuple, uint32_t type) | ||
| { | ||
| unsigned int dev_count = ARRAY_SIZE(uaol_devs); |
| #else | ||
| channel = copier_cfg->gtw_cfg.node_id.f.v_index; | ||
| #endif | ||
| break; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Intel USB Audio Offload Link (UAOL) DAI.
This PR needs another (Zephyr) PR drivers: dai: add DAI driver for Intel UAOL to be merged first.