Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline2.0: low hanging fruits - move buffers' common params to struct sof_audio_buffer. #9499

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

marcinszkudlinski
Copy link
Contributor

This PR moves many of parameters that are common for all buffers to struct sof_audio_buffer

there are 4 left:

	struct comp_dev *source;	/* source component */
	struct comp_dev *sink;		/* sink component */

	/* lists */
	struct list_item source_list;	/* list in comp buffers */
	struct list_item sink_list;	/* list in comp buffers */

and will be moved to sof_audio_buffer in next PR

a first / the first
procedure / function

Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
is_shared is a flag indicating that a buffer is shared
between cores.
This property is common for all types of audio buffers and
should be kept in a base structure

Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The is/are_hw_params seems rather minor.

@marcinszkudlinski
Copy link
Contributor Author

there's a problem with CI loadable library test, checking

hw_params_configured is a flag indicating that a buffer params has
been already set, and should be kept in the same structure as the
params themselves

this commit moves hw_params_configured to sof_audio_stream_params
and introduces API to handle the flag

Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
walking flag is not really needed for data buffering,
rather for pipeline iteration procedures, so it should
not be in sof_audio_buffer structure. But before in order
to make possible usage of other buffer types than comp_buffer
before pipeline2.0 is ready, it must be kept there.

Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
chmap is a parameter common for all types of buffers, should be
accessible through sink/src api, so it needs to be kept in
sof_audio_stream_params

an API inroduced for accessing the parameter

Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
@marcinszkudlinski
Copy link
Contributor Author

internal CI that was failing is green, jenkins did not start. Lately there was couple of similar problems in several PRs

BlobNotFoundThe specified blob does not exist. RequestId:edb2f1ad-201e-0086-7fa7-105dd6000000 Time:2024-09-27T06:33:40.4681943Z

@kv2019i
Copy link
Collaborator

kv2019i commented Sep 27, 2024

SOFCI TEST

@kv2019i kv2019i merged commit 64cb133 into thesofproject:main Sep 27, 2024
44 of 47 checks passed
@marcinszkudlinski marcinszkudlinski deleted the pipeline2_0_004 branch September 27, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants