Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: shell/winconsole_overlay: disable SOF telemetry #9514

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Sep 25, 2024

Workaround for #9513

Copy link
Contributor

@tobonex tobonex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could just disable performance measurements without disabling telemetry, but it's ok.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Sep 25, 2024

@tobonex If just disable PERFORMANCE_MEASUREMENTS, I get a build error for IO_MEASUREMENTS. If I disable also IO_PERFORMANCE_MEASUREMENTS with:

CONFIG_SOF_TELEMETRY_PERFORMANCE_MEASUREMENTS=n
CONFIG_SOF_TELEMETRY_IO_PERFORMANCE_MEASUREMENTS=n

... the DSP boot crashes on boot with debug build (I think due to an assert, I didn't get the log). With a non-debug build, it does boot up and the Zephyr shell works.

SOF telemetry performance measurement tools use the same window 3 as the
DSP winstream log backend and the latter is enabled in the shell
overlay. Disable the conflicting feature.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
SOF telemetry performance measurement tools use the same window 3 as the
DSP winstream log backend, so the two cannot be enabled at the same
time.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
Copy link
Collaborator Author

kv2019i commented Sep 25, 2024

New version uploaded:

  • only disable the PERFORMANCE_MEASUREMENTS options (that use window3)
  • disable in both overlays as both overlays use winstream backend and there's a clear conflict with window3

@lgirdwood lgirdwood merged commit b70d2bf into thesofproject:main Sep 26, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants