Platform: Library: Move mailbox_sw_reg_read64() from posix mailbox.h #9589
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change testbench IPC4 build fails with copier with implicit definition of the function. The mailbox_sw_reg_read64() function should be there in the same platform library mailbox.h header as the 32 bit version of similar function. The header mailbox.h for all Intel platforms is organized similarly. The argument type is changed to size_t from uint32_t to follow other similar functions. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
lgirdwood
reviewed
Oct 17, 2024
Comment on lines
-75
to
-76
| static inline uint64_t mailbox_sw_reg_read64(uint32_t offset) | ||
| { |
There was a problem hiding this comment.
Can testbench include this header ? We really want to get rid of platform/include now with Zephyr.
There was a problem hiding this comment.
The failure is not from testbench source code but rest of SOF code built into testbench.
singalsu
requested review from
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change testbench IPC4 build fails with copier with implicit definition of the function. The mailbox_sw_reg_read64() function should be there in the same platform library mailbox.h header as the 32 bit version of similar function. The header mailbox.h for all Intel platforms is organized similarly.
The argument type is changed to size_t from uint32_t to follow other similar functions.