-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoload shared libraries #78
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this feature, it makes sense to have. I’ve left code comments in review. You should also add some tests that touch this functionality in tests/test_save_load.py
Ok, I have applied all the comments.
|
I think the code changes for the library reloading are now good, but I'd like to see more tests:
|
Did you get a chance to resolve the comments above RE more robust testing? |
When a conifer JSON model is loaded conifer is not able to load also the conifer_bridge.so shared libraries (if they were already produced).
This implies:
This PR tries to fix this behavior by looking for the shared library with the last timestamp present in the metadata. It looks for it in the same folder of the JSON if the is not specified by the user.
It works for both the xilinx and cpp backends.