Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't visit added imported functions during application iteration. #194

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Don't visit added imported functions during application iteration. #194

merged 4 commits into from
Oct 1, 2024

Conversation

ejrgilbert
Copy link
Collaborator

@ejrgilbert ejrgilbert commented Sep 30, 2024 •
edited
Loading

Fixes several issues:

  1. Don't visit added imported functions during application iteration.
  2. Make sure skipped functions are always skipped, even after iterator reset.
  3. Make memory usage more efficient.
  4. Reduce duplicated code in project.

Still need to add testing before merge!

@ejrgilbert ejrgilbert requested review from thesuhas and removed request for thesuhas September 30, 2024 22:08
@ejrgilbert ejrgilbert marked this pull request as ready for review October 1, 2024 16:31
@ejrgilbert ejrgilbert merged commit ded87ff into main Oct 1, 2024
2 checks passed
@ejrgilbert ejrgilbert deleted the task/skip_added_imports_during_mod_iter branch October 1, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesuhas thesuhas Awaiting requested review from thesuhas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ejrgilbert