Fix devtools panel path for firefox

thetarnav · Dec 17, 2024 · d88ced2 · d88ced2
1 parent 99329a2
commit d88ced2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/.changeset/smart-apples-joke.md b/.changeset/smart-apples-joke.md
@@ -0,0 +1,5 @@
+---
+"@solid-devtools/extension": patch
+---
+
+Fix devtools panel path for firefox
diff --git a/packages/extension/devtools/devtools.ts b/packages/extension/devtools/devtools.ts
@@ -18,16 +18,18 @@ const port = chrome.runtime.connect({name: ConnectionName.Devtools})
 
 const {onPortMessage: fromBackground} = createPortMessanger(port)
 
+// Firefox requires absolute path
+const PATH_PREFIX = import.meta.env.BROWSER === 'firefox' ? '/' : ''
+
 // "Versions" mean that devtools client is on the page
 once(fromBackground, 'Versions', () => {
 
     log('Debugger connected -> Creating Devtools_Panel...')
 
     chrome.devtools.panels.create(
         'Solid',
-        // Firefox requires absolute path
-        (import.meta.env.BROWSER === 'firefox' ? '/' : '') + icons.disabled[32],
-        'index.html',
+        PATH_PREFIX + icons.disabled[32],
+        PATH_PREFIX + 'index.html',
         () => {
             if (chrome.runtime.lastError) {
                 error('Creating Devtools_Panel Failed', chrome.runtime.lastError)