Refactor registration_controller.rb (#250)

Several refactors to simplify and consolidate logic in registration controller, as well as related tests and model
thewca · Oct 11, 2023 · 9d58250 · 9d58250
1 parent c0abc91
commit 9d58250
Show file tree

Hide file tree

Showing 20 changed files with 353 additions and 469 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -11,6 +11,10 @@ AllCops:
 Bundler/OrderedGems:
   Enabled: false
 
+Lint/MissingSuper:
+  Exclude: 
+    - 'lib/registration_error.rb'
+
 Lint/EmptyWhen:
   Enabled: false
 
@@ -224,4 +228,4 @@ Style/HashSyntax:
 Style/GlobalVars:
   AllowedVariables:
     - $sqs
-    - $dynamodb
+    - $dynamodb
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
@@ -33,8 +33,12 @@ def performance_profile(&)
     end
   end
 
-  def render_error(status, error)
+  def render_error(http_status, error)
     Metrics.registration_validation_errors_counter.increment
-    render json: { error: error }, status: status
+    render json: { error: error }, status: http_status
+  end
+
+  rescue_from ActionController::ParameterMissing do |e|
+    render json: { error: ErrorCodes::INVALID_REQUEST_DATA }, status: :bad_request
   end
 end