Refactor registration_controller.rb #250

dunkOnIT · 2023-10-06T13:17:34Z

This PR introduces a number of refactors intended to reduce duplication, make the code simpler, and make some other minor improvements we've been speaking about.

Resolves #245

FinnIckler · 2023-10-06T13:43:13Z

Any way we can get this rebased ;)?

dunkOnIT · 2023-10-06T15:15:45Z

Lol yes my soul left my body once I came to the PR. Will get it done on Sunday :D

dunkOnIT · 2023-10-08T11:10:02Z

@FinnIckler the diff is now accurate. Do we care about trying to resolve the long commit chain?

dunkOnIT · 2023-10-09T07:35:30Z

Look into disabling rubocop super check only for RegistrationError

app/controllers/registration_controller.rb

dunkOnIT · 2023-10-09T07:48:46Z

In validate_create_request, have a user_can_create_registration method that aliases to shared logic
Considering refactoring the "only admins can register if comp is open (put that in the user_can_create_registration)
do raise/unless on one line
Ask ChatGPT about rewriting if params.key?(:competing)

FinnIckler

Just what we talked about in the call

dunkOnIT · 2023-10-10T12:56:48Z

All changes made, just need to go over the diff once my brain has a second to reset

dunkOnIT and others added 30 commits June 14, 2023 13:17

split tests into different folders

5a9b51b

set up dynamoid test/dev env and added db tests

9d5cb1f

fixed context naming and syntax errors

4833a0a

Made database_functions_spec.rb pass

ee1faac

added parametrized tests for post_registration

c37d55c

merged with origin

7db9537

rubocop changes

0e67f01

Made get_registration_spec pass

10e9760

merged main into rswag-testing

1903b36

merged with rswag-testing changes

817efa3

missed merge conflict

eb56ce7

added back post_attendee_spec.rb

1f3b99a

post attendee spec tests added

b9a122a

fixed parametrization of tests

cf52323

removed old db test and started PATCH tests

69d0290

working PATCH cancel happy path tests

a755c10

updated routes and finished cancel tests (against wrng path)

8da0f8f

working reg cancel tests

459d14d

made cancel into a separate file

f9ad227

made cancel into a separate file and added it

2b4a54b

updated spec with new request format, added update registrations

78b9fc4

merged with main

36e9a57

trying to pass post tests

58b7156

working JWT token submission

b40cbf2

jwt working, code cleaned up

c82a397

cursed attempts to make tests work

5be91ae

various failed attempts to make shared examples work

d80debc

dead-end: testing to make shared examples work

e395fef

DEAD-END: testing to make shared examples work

e97ad94

post_attendee first test passes controller

160d6f8

dunkOnIT added 14 commits October 3, 2023 11:48

removed puts and moved changed_event_ids to lanes.rb

5756af6

removed registration_status and enable_traces

182670f

removed registration_status and enable_traces

7e3aadf

PR changes and added overcommit

44ff150

changed overcommit config

819f86d

changed overcommit ymlspacing

6c29044

rubocop changes

287f8d7

final review changes

e73873c

removed unnecessary puts

1b9fff4

fixed error codes

9188b64

changed comp update format and refactored reg controller

d4b333f

more controller refactors

7ceb4ef

removed user impersonation, cleaned up error rendering

b5e527e

finished refactor points in issue

cf30cd8

merged with master

b929809

dunkOnIT commented Oct 9, 2023

View reviewed changes

app/controllers/registration_controller.rb Outdated Show resolved Hide resolved

dunkOnIT added 2 commits October 9, 2023 10:30

disabled super check only for RegistrationError

3a3db0a

excluded super check from RegistrationError

db075b7

FinnIckler approved these changes Oct 9, 2023

View reviewed changes

dunkOnIT added 2 commits October 10, 2023 04:03

1-liner if and unless

f4b8a82

rubocop changes

1ec62c6

explicitly defining test environment

55b88ae

dunkOnIT merged commit 9d58250 into main Oct 11, 2023
1 check passed

dunkOnIT deleted the refactor-competition-validations branch October 11, 2023 07:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor registration_controller.rb #250

Refactor registration_controller.rb #250

dunkOnIT commented Oct 6, 2023

FinnIckler commented Oct 6, 2023

dunkOnIT commented Oct 6, 2023

dunkOnIT commented Oct 8, 2023 •

edited

Loading

dunkOnIT commented Oct 9, 2023 •

edited

Loading

dunkOnIT commented Oct 9, 2023 •

edited

Loading

FinnIckler left a comment

dunkOnIT commented Oct 10, 2023

Refactor registration_controller.rb #250

Refactor registration_controller.rb #250

Conversation

dunkOnIT commented Oct 6, 2023

FinnIckler commented Oct 6, 2023

dunkOnIT commented Oct 6, 2023

dunkOnIT commented Oct 8, 2023 • edited Loading

dunkOnIT commented Oct 9, 2023 • edited Loading

dunkOnIT commented Oct 9, 2023 • edited Loading

FinnIckler left a comment

Choose a reason for hiding this comment

dunkOnIT commented Oct 10, 2023

dunkOnIT commented Oct 8, 2023 •

edited

Loading

dunkOnIT commented Oct 9, 2023 •

edited

Loading

dunkOnIT commented Oct 9, 2023 •

edited

Loading