Skip to content
This repository has been archived by the owner on Jan 3, 2025. It is now read-only.

Updated get_registrations and post_attendee tests #133

Merged
merged 74 commits into from
Oct 6, 2023
Merged

Updated get_registrations and post_attendee tests #133

merged 74 commits into from
Oct 6, 2023

Conversation

dunkOnIT
Copy link
Collaborator

@dunkOnIT dunkOnIT commented Aug 1, 2023 •
edited
Loading

Outstanding items:

  • Swaggerize output and check Swagger UI (help required on accessing the UI)
  • Discuss merging tests with a FAILING flag
  • Review diff

dunkOnIT and others added 30 commits June 14, 2023 13:17
@dunkOnIT
split tests into different folders
5a9b51b
@dunkOnIT
set up dynamoid test/dev env and added db tests
9d5cb1f
@dunkOnIT
fixed context naming and syntax errors
4833a0a
@FinnIckler
Made database_functions_spec.rb pass
ee1faac
@dunkOnIT
added parametrized tests for post_registration
c37d55c
@dunkOnIT
merged with origin
7db9537
@dunkOnIT
rubocop changes
0e67f01
@FinnIckler
Made get_registration_spec pass
10e9760
@dunkOnIT
merged main into rswag-testing
1903b36
@dunkOnIT
merged with rswag-testing changes
817efa3
@dunkOnIT
missed merge conflict
eb56ce7
@dunkOnIT
added back post_attendee_spec.rb
1f3b99a
@dunkOnIT
post attendee spec tests added
b9a122a
@dunkOnIT
fixed parametrization of tests
cf52323
@dunkOnIT
removed old db test and started PATCH tests
69d0290
@dunkOnIT
working PATCH cancel happy path tests
a755c10
@dunkOnIT
updated routes and finished cancel tests (against wrng path)
8da0f8f
@dunkOnIT
working reg cancel tests
459d14d
@dunkOnIT
made cancel into a separate file
f9ad227
@dunkOnIT
made cancel into a separate file and added it
2b4a54b
@dunkOnIT
updated spec with new request format, added update registrations
78b9fc4
@dunkOnIT
merged with main
36e9a57
@dunkOnIT
trying to pass post tests
58b7156
@dunkOnIT
working JWT token submission
b40cbf2
@dunkOnIT
jwt working, code cleaned up
c82a397
@dunkOnIT
cursed attempts to make tests work
5be91ae
@dunkOnIT
various failed attempts to make shared examples work
d80debc
@dunkOnIT
dead-end: testing to make shared examples work
e395fef
@dunkOnIT
DEAD-END: testing to make shared examples work
e97ad94
@dunkOnIT
post_attendee first test passes controller
160d6f8
@dunkOnIT
Copy link
Collaborator Author

dunkOnIT commented Oct 3, 2023 •
edited
Loading

  • Move REGISTRATION_STATUS to model
  • Move competition errors to registration errors

Research:

  • Research filter/map functions
  • Output logs to file?

@dunkOnIT
Copy link
Collaborator Author

dunkOnIT commented Oct 3, 2023 •
edited
Loading

  • Get all tests passing with current code state
  • Set up a pre-commit hook to run rubocop
  • Run rubocop
  • Remove allow_net_connect and check if tests run

FinnIckler
FinnIckler suggested changes Oct 3, 2023
View reviewed changes
app/controllers/application_controller.rb Outdated Show resolved Hide resolved
app/controllers/registration_controller.rb Show resolved Hide resolved
config/environments/development.rb Outdated Show resolved Hide resolved
app/helpers/competition_api.rb Outdated Show resolved Hide resolved
app/helpers/competition_api.rb Outdated Show resolved Hide resolved
app/helpers/competition_api.rb Outdated
end

if competition_info[:error] == false
competition_info[:competition_exists?] = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reconsider if we need these two booleans

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to leave them in and then refactor the competition_api.rb once the PR is merged, as discussed.

@dunkOnIT
Copy link
Collaborator Author

dunkOnIT commented Oct 4, 2023

@FinnIckler ready for final review!

@dunkOnIT dunkOnIT merged commit c0abc91 into main Oct 6, 2023
1 check passed
@dunkOnIT dunkOnIT deleted the rswag-testing branch October 6, 2023 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FinnIckler FinnIckler FinnIckler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dunkOnIT @FinnIckler