Refactor tests to use factories instead of fixtures

[dunkOnIT]

TODO:

• create factories
• refactor validations into a service
• check if we have all validations (just take a look for any validation functions missing from controller
• change validate_update_request to use checker service, get old tests running
• go through all old tests, make sure we have the cases covered (add them to a spreadsheet?)
• once cases are covered, check files for commented out lines and puts statements
• push and flag for review :)

[dunkOnIT]

• Need help resolving the lane_factory conflict
• Just pushing the new stuff for now, will refactor the RSwag tests in a later PR

[dunkOnIT]

• Rewrite comeptitor_count function to (a) only consider registrations for one competition, (b) use where instead of all (consider using a nested query here)
• Add tests for registration acceptance where different comps have different numbers of competitors
• Make target_user_id = @request['user_id'].to_s as an instance variable in the functions, instead of calling it every time

[FinnIckler]

as per call

[dunkOnIT]

• registration_spec.rb should query database to make sure that is_competing status change are persisting - we shouldn't just test the object in memory