This repository has been archived by the owner on Jan 3, 2025. It is now read-only.
Handle no-competitor-limit UI cases #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the new design completely removed the accordion, because we will move it to an extra step in the step panel. Something like 'these are the requirements, do you agree?", so this is definitely all reusable content wise! |
|
and thanks for the whitespace gregor definitely agrees haha |
FinnIckler
approved these changes
Dec 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some more information to the registration table headers. Though as noted, some kind of sticky/floating box somewhere, which always stays in sight, would probably be a better solution in the future.
This will create more conflicts with the new design PR, since the accordion was completely redone there.
I don't think the codebase has enough blank lines separating chunks of code. 😃