Skip to content
This repository has been archived by the owner on Jan 3, 2025. It is now read-only.

Prevent accepting too many registrations at once (FE) #381

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

kr-matthews
Copy link
Contributor

@kr-matthews kr-matthews commented Dec 6, 2023

The backend seems to allow this?

Edit: It would probably be good to have a test for this?

@kr-matthews kr-matthews self-assigned this Dec 6, 2023
@FinnIckler
Copy link
Member

interesting, I know we have a test for this on the backend. I will try it out and see what's going on

@kr-matthews
Copy link
Contributor Author

kr-matthews commented Dec 7, 2023

I still think a frontend test would be good because without my changes if you select more rows than spots are available, the first few will be accepted before the rest are rejected and if the organizer didn't select the rows in the correct order (thinking it didn't matter) then the wrong competitors would get accepted.
ie even if the backend works perfectly, the frontend is still picking a (potentially unintuitive) order to accept the selected registrations in, so preventing accepting too many at once (as opposed to accepting the first few then stopping at the limit) seems pretty important and should have a test.

@FinnIckler
Copy link
Member

I added a Test Competition with Low Limit

@FinnIckler FinnIckler merged commit 91a951f into thewca:main Dec 11, 2023
1 check passed
@kr-matthews kr-matthews deleted the fe-prevent-accepting-over-limit branch December 11, 2023 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants