This repository has been archived by the owner on Jan 3, 2025. It is now read-only.
Request qualification data at the current date, not the future qualification date #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monolith qualification_data endpoint takes an optional date parameter, for specifying the date on which the qualification data should be computed for the user. wca-registration submits a request to this endpoint using the whenDate of the qualification. However, if the whenDate for the qualification is in the future, the monolith rejects this request, because we cannot compute qualifications for future dates.
This PR makes wca-registration request qualifications at the earlier of the qualification date or today's date.