This repository has been archived by the owner on Jan 3, 2025. It is now read-only.
Default competitor limit to 0 if null #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After seeing TexasFMCChampionship, I thought all comps without a competitor limit were defaulted to 0.
However, FMCArgentina has a competitor_limit of null in the JSON payload.
As a hotfix for v2, I'm defaulting competitor_limit to 0 if it is nil.
The better approach is what we're now using in v3, which is to query the
competitor_limit_enabledproperty directly. We could expose this in the competition JSON, but given that we want to phase out v2 soon it didn't seem necessary.