Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support loading device certificate from multiple locations (env, secrets, file) #37

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

reubenmiller
Copy link
Contributor

Support loading the device certificate from different sources:

  • From base64 encoded environment variables (CERTPRIVATE and CERTPUBLIC)
  • From docker secrets, called certificate_private_key and certificate_public_key
  • From file (e.g. using a volume which contains an already created certificate)

The first found certificate (regardless if it is valid or not) will be taken.

Copy link

github-actions bot commented Oct 9, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
12 0 1 12 100 1m18.020305s

Passed Tests

Name ⏱️ Duration Suite
Grace period to allow container to startup 5.003 s Operations
Get Logfile Request 2.348 s Operations
Get Configuration File 4.644 s Operations
Execute Shell Command 2.320 s Operations
Install application using docker compose 21.527 s Operations
Get Container Logs 2.324 s Operations
Trigger self update via local command 11.415 s Self-Update
Self update should only update if there is a new image 2.323 s Self-Update
Self update using software update operation 23.325 s Self-Update
Cloud Connection is Online 0.121 s Telemetry
Service status 0.222 s Telemetry
Sends measurements 2.447 s Telemetry

@reubenmiller reubenmiller force-pushed the feat-support-loading-cert-from-env-again branch from 5d04a4e to 67078a9 Compare October 9, 2024 20:11
@reubenmiller reubenmiller added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit c5d10e3 Oct 9, 2024
2 checks passed
@reubenmiller reubenmiller deleted the feat-support-loading-cert-from-env-again branch October 9, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant