Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(container-group): fix the service type when publishing the down status #32

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

reubenmiller
Copy link
Collaborator

Fix a problem with the container-group service status where the service name used to publish the uninstalled status was using :: instead of @ as the compose project/service separator.

The up status was already using the @ separator.

Before

name: myproject::nginx

After

name: myproject@nginx

Copy link

github-actions bot commented Feb 7, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
6 0 1 6 100 45.172999999s

Passed Tests

Name ⏱️ Duration Suite
Get Configuration 4.791 s Operations
Install container-group package 13.501 s Operations
Uninstall container-group 2.635 s Operations
Install container package 13.203 s Operations
Uninstall container package 2.482 s Operations
Service status 8.560 s Telemetry-Main

@reubenmiller reubenmiller added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit f9ce5ac Feb 7, 2024
3 checks passed
@reubenmiller reubenmiller deleted the fix-container-group-service-type branch February 7, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant