Skip to content

fix: remove pid from service status messages #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

reubenmiller
Copy link
Collaborator

Remove the pid from the service status messages as it was causing the service status message to be ignored by thin-edge.io (due to the pid data type changing from a string to an integer).

Since the pid information did not provide any useful information, it was removed all together.

Copy link

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
7 0 1 7 100 1m5.518s

Passed Tests

Name ⏱️ Duration Suite
Get Configuration 4.794 s Operations
Install container-group package 13.411 s Operations
Install container-group with multiple files 26.891 s Operations
Uninstall container-group 2.555 s Operations
Install container package 15.319 s Operations
Uninstall container package 2.439 s Operations
Service status 0.108 s Telemetry-Main

@reubenmiller reubenmiller added this pull request to the merge queue Sep 21, 2024
Merged via the queue into main with commit a0b10ba Sep 21, 2024
3 checks passed
@reubenmiller reubenmiller deleted the fix-service-status-pid-datatype branch November 7, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant