fix: prevent update loop when using ObservableObjects (fixes #10)

Sources/SwiftlySearch/SwiftlySearch.swift

@@ -107,6 +107,8 @@ struct SearchBar<ResultContent: View>: UIViewControllerRepresentable {
         // MARK: - UISearchResultsUpdating
         func updateSearchResults(for searchController: UISearchController) {
             guard let text = searchController.searchBar.text else { return }
+            // Make sure the text has actually changed (workaround for #10).
+            guard text != self.text else { return }
             DispatchQueue.main.async {
                 self.text = text
             }

Tests/TestApp/ContentView.swift

@@ -19,6 +19,10 @@ struct ContentView: View {
                 NavigationLink(destination: CallbackUpdateTest()) {
                     Text("Callback Update")
                 }
+
+                NavigationLink(destination: ObservablePublishedTest()) {
+                    Text("Observable Published")
+                }
             }
             .navigationBarTitle("Tests")
         }

Tests/TestApp/TestViews/ObservablePublishedTest.swift

@@ -0,0 +1,22 @@
+import SwiftUI
+
+class ObservablePublishedModel: ObservableObject {
+    @Published var searchText = ""
+}
+
+struct ObservablePublishedTest: View {
+    @ObservedObject var viewModel = ObservablePublishedModel()
+
+    var body: some View {
+        List {
+            Text("foo")
+        }
+        .navigationBarSearch($viewModel.searchText)
+    }
+}
+
+struct ObservablePublishedTest_Previews: PreviewProvider {
+    static var previews: some View {
+        ObservablePublishedTest()
+    }
+}

Tests/UITests/ObservablePublishedTests.swift

@@ -0,0 +1,17 @@
+// I was unable to get this test to work, but I'm leaving it in as a reminder for the future.
+
+//import XCTest
+//
+//class ObservablePublishedTests: UITest {
+//    func testObservablePublishedMetric() throws {
+//        selectTest("Observable Published")
+//
+//        measure(metrics: [XCTCPUMetric(application: app)]) {
+//            app.children(matching: .any).firstMatch.slowSwipeDown(offset: 0.5, distance: 0.1)
+//
+//            // Ensure the searchbar exists.
+//            let navBar = app.navigationBars.firstMatch
+//            XCTAssertTrue(navBar.children(matching: .searchField).firstMatch.exists, "Searchbar exists")
+//        }
+//    }
+//}