-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Add group creation and registration functionality #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into 1632-epic-create-groups
…oup-registration' into 1632-epic-create-groups
…-registration' into 1632-epic-create-groups
…ception' into 1632-epic-create-groups
Zitrone44
requested changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far 👍
Only the following comments:
modules/fbs-core/api/src/main/resources/migrations/21_user_group_field_added.sql
Show resolved
Hide resolved
modules/fbs-core/api/src/main/scala/de/thm/ii/fbs/controller/GroupRegistrationController.scala
Show resolved
Hide resolved
Zitrone44
previously approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works 👍
Zitrone44
approved these changes
May 28, 2024
Medienkunzt
pushed a commit
that referenced
this pull request
May 28, 2024
* adding mongodb and minio to core depencies in docker-compose.yml (#1649) Co-authored-by: Sven Roman Reinhard <sven.roman.reinhard@mni.thm.de> * fix(ci): try disabling coverage again * adding äÄöÖüÜߧ²³°´? to allowed chars in sql play ground (#1647) adding äÄöÖüܧ²³°´ to allowed chars in sql play ground Co-authored-by: Sven Roman Reinhard <sven.roman.reinhard@mni.thm.de> * [API] Add group creation and registration functionality (#1640) * #1633 * Create model for groups (#1633) * Add group controller (#1634) * Add group service (#1634) * Add migration for user group field (#1635) * Add Controller for Group Registration (#1636) * Add Service for Group Registration (#1636) * Add MembershipExceedException (#1637) * Correct lint errors (#1632) * docs(core): update api docs with group routes --------- Co-authored-by: Jonas Kuche <jonas-ian.kuche@mni.thm.de> --------- Co-authored-by: Sven Roman Reinhard <sven.roman.reinhard@mni.thm.de> Co-authored-by: Jonas Kuche <Zitrone44@users.noreply.github.com> Co-authored-by: Sophie Methe <159429982+scmet@users.noreply.github.com> Co-authored-by: Jonas Kuche <jonas-ian.kuche@mni.thm.de>
Medienkunzt
pushed a commit
that referenced
this pull request
May 28, 2024
…(x) (#1659) * removed trailing spaces from dbentries. Replaced CHAR(x) with VARCHAR(x) * plz is now char not varchar * PLZ is now CHAR(5) not VARCHAR(5) (#1660) * adding mongodb and minio to core depencies in docker-compose.yml (#1649) Co-authored-by: Sven Roman Reinhard <sven.roman.reinhard@mni.thm.de> * fix(ci): try disabling coverage again * adding äÄöÖüÜߧ²³°´? to allowed chars in sql play ground (#1647) adding äÄöÖüܧ²³°´ to allowed chars in sql play ground Co-authored-by: Sven Roman Reinhard <sven.roman.reinhard@mni.thm.de> * [API] Add group creation and registration functionality (#1640) * #1633 * Create model for groups (#1633) * Add group controller (#1634) * Add group service (#1634) * Add migration for user group field (#1635) * Add Controller for Group Registration (#1636) * Add Service for Group Registration (#1636) * Add MembershipExceedException (#1637) * Correct lint errors (#1632) * docs(core): update api docs with group routes --------- Co-authored-by: Jonas Kuche <jonas-ian.kuche@mni.thm.de> --------- Co-authored-by: Sven Roman Reinhard <sven.roman.reinhard@mni.thm.de> Co-authored-by: Jonas Kuche <Zitrone44@users.noreply.github.com> Co-authored-by: Sophie Methe <159429982+scmet@users.noreply.github.com> Co-authored-by: Jonas Kuche <jonas-ian.kuche@mni.thm.de> --------- Co-authored-by: Sven Roman Reinhard <sven.roman.reinhard@mni.thm.de> Co-authored-by: Jonas Kuche <Zitrone44@users.noreply.github.com> Co-authored-by: Sophie Methe <159429982+scmet@users.noreply.github.com> Co-authored-by: Jonas Kuche <jonas-ian.kuche@mni.thm.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.