Fix non_pivot_cols_of_ref

thofma · Jun 3, 2023 · a4994b5 · a4994b5
1 parent 90416a7
commit a4994b5
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/Misc/Matrix.jl b/src/Misc/Matrix.jl
@@ -207,20 +207,20 @@ function non_pivot_cols_of_ref(H::MatrixElem)
   i = 1
   for j in axes(H, 2)
     is_zero_entry(H, i, j) ? push!(p, j) : (i+=1)
+    i == nrows(H)+1 && break
   end
   return p
 end
 
 function rank_of_ref(H::MatrixElem)
-  i = 0
+  i = 1
   for j in axes(H, 2)
-    is_zero_entry(H, i+1, j) || (i+=1)
-    i == nrows(H) && return i
+    is_zero_entry(H, i, j) || (i+=1)
+    i == nrows(H)+1 && break
   end
-  return i
+  return i-1
 end
 
-
 transpose!(A::Union{ZZMatrix, QQMatrix}) = is_square(A) ? transpose!(A, A) : transpose(A)
 
 function transpose!(A::ZZMatrix, B::ZZMatrix)