Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate field_of_fractions(O::GenOrd) #1240

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

felix-roehrich
Copy link
Contributor

@felix-roehrich felix-roehrich commented Oct 10, 2023

A quick search shows that field_of_fractions isn't used anywhere, but causes confusion with fraction_field used in OSCAR and co.
I am not sure if simply removing or offering fraction_field as an alias of function_field is better. For now I think it is best to deprecate field_of_fractions.

@thofma
Copy link
Owner

thofma commented Oct 10, 2023

Looks good. Could you move the deprecation to https://github.com/thofma/Hecke.jl/blob/master/src/Deprecations.jl? Thanks.

@felix-roehrich
Copy link
Contributor Author

Done.

@felix-roehrich
Copy link
Contributor Author

Please approve the workflows.

@felix-roehrich
Copy link
Contributor Author

"Run long tests" timed out. But I guess this still can be merged, since ~1.10.0 is failing anyway ?

@thofma
Copy link
Owner

thofma commented Oct 12, 2023

I have restarted it.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (41b61f3) 74.59% compared to head (c426b72) 74.51%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1240      +/-   ##
==========================================
- Coverage   74.59%   74.51%   -0.08%     
==========================================
  Files         346      346              
  Lines      110839   110837       -2     
==========================================
- Hits        82681    82592      -89     
- Misses      28158    28245      +87     
Files Coverage Δ
src/Deprecations.jl 4.54% <ø> (ø)
src/FunField/Divisor.jl 80.08% <ø> (+0.68%) ⬆️

... and 36 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit 08c93fe into thofma:master Oct 12, 2023
13 of 16 checks passed
@felix-roehrich felix-roehrich deleted the fr-deprecate-field_of_fractions branch October 27, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants