Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded broken line in class group proof #1249

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

alexjbest
Copy link
Contributor

This line was failing for me when I tried to compute class groups with GRH=false

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6d81413) 74.54% compared to head (dd76876) 74.66%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
+ Coverage   74.54%   74.66%   +0.11%     
==========================================
  Files         346      346              
  Lines      110838   110996     +158     
==========================================
+ Hits        82627    82877     +250     
+ Misses      28211    28119      -92     
Files Coverage Δ
src/NumFieldOrd/NfOrd/Clgp/Proof.jl 36.55% <ø> (+0.38%) ⬆️
src/Misc/MSet.jl 96.23% <98.58%> (+46.49%) ⬆️

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit 962cb98 into thofma:master Oct 17, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants