Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Jordan normal form #1280

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fix Jordan normal form #1280

merged 1 commit into from
Nov 9, 2023

Conversation

joschmitt
Copy link
Collaborator

Fixes #1279 .

fieker
fieker approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@fieker fieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, thanks

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1280 (a8af322) into master (d65dbb3) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1280      +/-   ##
==========================================
- Coverage   74.58%   74.56%   -0.02%     
==========================================
  Files         346      346              
  Lines      111379   111380       +1     
==========================================
- Hits        83070    83051      -19     
- Misses      28309    28329      +20
Files Coverage Δ
src/Misc/jordan.jl 58.04% <100.00%> (+0.22%) ⬆️
src/NumField/QQ.jl 53.12% <100.00%> (+1.92%) ⬆️

... and 28 files with indirect coverage changes

@thofma thofma merged commit 829741c into thofma:master Nov 9, 2023
16 of 17 checks passed
@joschmitt joschmitt deleted the jordan branch November 9, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fieker fieker fieker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jordan normal form broken over number field
3 participants
@joschmitt @fieker @thofma