Improve Plesken--Souvignier #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1320 +/- ##
==========================================
+ Coverage 74.64% 74.67% +0.03%
==========================================
Files 346 346
Lines 111576 112086 +510
==========================================
+ Hits 83286 83701 +415
- Misses 28290 28385 +95
|
joschmitt
force-pushed
the
vector_sums
branch
from
4510adc to
53b72ae
Compare
|
I'm happy with the test coverage for now. |
|
Thanks a lot for this PR! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the "vector sums" method from the paper by Plesken--Souvignier.
I will probably add more tests once the coverage report is in.
@thofma I tell you more about the changes tomorrow.