Support for arbitrary ring morphisms with number field domains #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
reviewed
Dec 15, 2023
| @@ -322,7 +322,7 @@ function map_data_type(T::Type{<: NfRel}, L::Type{<:Any}) | |||
| MapDataFromNfRel{elem_type(L), map_data_type(base_field_type(T), L)} | |||
| end | |||
|
|
|||
| map_data_type(K::NfRel, L::NumField) = map_data_type(typeof(K), typeof(L)) | |||
| map_data_type(K::NfRel, L::Ring) = map_data_type(typeof(K), typeof(L)) | |||
There was a problem hiding this comment.
This is duplicate to line 1041
There was a problem hiding this comment.
Hm yes, all the f(x, y) = f(typeof(x), typeof(y)) could be consolidated. But I don't have time for this clean up now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.