Absolute value in short vectors (iteration) #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1327 +/- ##
==========================================
- Coverage 74.67% 74.59% -0.08%
==========================================
Files 346 346
Lines 112088 112098 +10
==========================================
- Hits 83697 83624 -73
- Misses 28391 28474 +83
|
thofma
reviewed
Dec 15, 2023
| @@ -45,7 +45,7 @@ | |||
| 2448, 4320, 2982, 2402, 2364, 512, 256, 306 ] | |||
|
|
|||
| # Floating point bounds | |||
| L = integer_lattice(gram = QQ[1//2 0; 0 1//3]) | |||
There was a problem hiding this comment.
I would duplicate the tests instead of removing the old tests.
There was a problem hiding this comment.
Good point, I will modify this.
|
The "absolute quadratic form" sounds a bit odd, as does the "absolute squared length". But I guess it is what it is. You have an opinion on the terminology @simonbrandhorst? |
simonbrandhorst
approved these changes
Dec 16, 2023
src/QuadForm/ShortVectors.jl
Outdated
Comment on lines
154
to
155
| Return the Kissing number of the sphere packing defined by the absolute value | ||
| of the quadratic form defined by `L`. |
There was a problem hiding this comment.
Suggested change
| Return the Kissing number of the sphere packing defined by the absolute value | |
| of the quadratic form defined by `L`. | |
| Return the Kissing number of the sphere packing defined by `L`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.