Add comments on the implementation of local Hilbert symbols #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Superb! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1328 +/- ##
==========================================
+ Coverage 74.67% 74.70% +0.03%
==========================================
Files 346 346
Lines 112088 112089 +1
==========================================
+ Hits 83697 83734 +37
+ Misses 28391 28355 -36
|
|
Do we have to update and re-run all the checks for "nothing" ? |
thofma
force-pushed
the
sm/comments_in_markus_code
branch
from
6cffd3b to
8481591
Compare
thofma
force-pushed
the
sm/comments_in_markus_code
branch
from
8481591 to
8c263d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markus Kirschmer explained me how his code works, so I have added some comments related to this.
Now we have details about the process and why the output is what we want ( + some references for free)