Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'check' argument to several divexact methods #1332

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

fingolfin
Copy link
Contributor

We need this in order to write generic code

We need this in order to write generic code
@fingolfin
Copy link
Contributor Author

Turns out there were also a few divexact methods which had a check argument but it was positional, not a keyword argument... The second commit now fixes these. But I guess this makes this technically speaking a breaking change, in case anyone was using this third argument sigh.

@fingolfin
Copy link
Contributor Author

I will add compatibility shims to src/Deprecations.jl to avoid the breakage

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Merging #1332 (f73db83) into master (fac876f) will decrease coverage by 0.02%.
The diff coverage is 73.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1332      +/-   ##
==========================================
- Coverage   74.63%   74.61%   -0.02%     
==========================================
  Files         346      346              
  Lines      112109   112109              
==========================================
- Hits        83675    83653      -22     
- Misses      28434    28456      +22     
Files Coverage Δ
src/Deprecations.jl 4.54% <ø> (ø)
src/LocalField/Elem.jl 80.37% <100.00%> (ø)
src/LocalField/Poly.jl 63.30% <100.00%> (ø)
src/LocalField/Ring.jl 69.36% <100.00%> (ø)
src/NumField/NfRel/NfRel.jl 78.55% <100.00%> (ø)
src/NumFieldOrd/NfRelOrd/Ideal.jl 87.21% <100.00%> (ø)
src/NumFieldOrd/NumFieldOrdElem.jl 94.15% <100.00%> (ø)
src/QuadForm/QuadBin.jl 85.41% <100.00%> (ø)
src/Sparse/Row.jl 82.44% <100.00%> (ø)
src/AlgAssAbsOrd/Ideal.jl 75.74% <50.00%> (ø)
... and 6 more

... and 25 files with indirect coverage changes

@thofma thofma merged commit 4fb1f9b into thofma:master Dec 22, 2023
17 of 18 checks passed
@thofma
Copy link
Owner

thofma commented Dec 22, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants