-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix root_lattice_recognition
#1349
Conversation
@simonbrandhorst looks good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please sort the output of root_lattice_recognition
?
This would assure a consistent output and that two root lattices are isometric
if and only if the root_lattice_recognition
output coincided.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1349 +/- ##
==========================================
+ Coverage 70.24% 70.31% +0.06%
==========================================
Files 351 351
Lines 111802 111809 +7
==========================================
+ Hits 78539 78621 +82
+ Misses 33263 33188 -75
|
Co-authored-by: Simon Brandhorst <brandhorst@math.uni-sb.de>
Thanks for taking care of this. |
root_sublattice
allowed odd root lattices but the recognition function did not. So I introduce the root lattice@simonbrandhorst