Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix root_lattice_recognition #1349

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

StevellM
Copy link
Collaborator

root_sublattice allowed odd root lattices but the recognition function did not. So I introduce the root lattice $I_1$ for odd lattices, which is just the odd (positive definite) unimodular lattice of rank 1.
@simonbrandhorst

@thofma
Copy link
Owner

thofma commented Jan 16, 2024

@simonbrandhorst looks good to you?

Copy link
Collaborator

@simonbrandhorst simonbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please sort the output of root_lattice_recognition?
This would assure a consistent output and that two root lattices are isometric
if and only if the root_lattice_recognition output coincided.

src/QuadForm/Quad/ZLattices.jl Outdated Show resolved Hide resolved
src/QuadForm/Quad/ZLattices.jl Outdated Show resolved Hide resolved
src/QuadForm/Quad/ZLattices.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Merging #1349 (4ce6b77) into master (e4adbe5) will increase coverage by 0.06%.
The diff coverage is 85.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
+ Coverage   70.24%   70.31%   +0.06%     
==========================================
  Files         351      351              
  Lines      111802   111809       +7     
==========================================
+ Hits        78539    78621      +82     
+ Misses      33263    33188      -75     
Files Coverage Δ
src/QuadForm/Quad/ZLattices.jl 94.17% <85.71%> (+1.01%) ⬆️

... and 27 files with indirect coverage changes

Co-authored-by: Simon Brandhorst <brandhorst@math.uni-sb.de>
@simonbrandhorst
Copy link
Collaborator

Thanks for taking care of this.

@simonbrandhorst simonbrandhorst merged commit b76e7e1 into thofma:master Jan 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants