Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to Nemo 0.40 #1362

Merged
merged 14 commits into from
Jan 26, 2024
Merged

Adjust to Nemo 0.40 #1362

merged 14 commits into from
Jan 26, 2024

Conversation

lgoettgens
Copy link
Contributor

@lgoettgens lgoettgens commented Jan 23, 2024

Includes and thus closes #1361.
Includes and thus closes #1356.
Includes and thus closes #1344.

@lgoettgens lgoettgens force-pushed the lg/nemo-bump branch 3 times, most recently from 6c72843 to 12f5c29 Compare January 24, 2024 13:10
@lgoettgens
Copy link
Contributor Author

This now contains everything I already knew that has to be adapted. Let's see what else fails...

@lgoettgens
Copy link
Contributor Author

The next error is in

due to Nemocas/Nemo.jl#1620. I have no idea how to fix that, can you have a look @thofma?

@thofma
Copy link
Owner

thofma commented Jan 24, 2024

Yes, I will adjust it

@thofma thofma marked this pull request as ready for review January 25, 2024 19:59
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Merging #1362 (a6c8d85) into master (0526c55) will decrease coverage by 0.19%.
Report is 2 commits behind head on master.
The diff coverage is 64.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1362      +/-   ##
==========================================
- Coverage   70.46%   70.28%   -0.19%     
==========================================
  Files         351      351              
  Lines      111821   111785      -36     
==========================================
- Hits        78798    78563     -235     
- Misses      33023    33222     +199     
Files Coverage Δ
src/AlgAss/AbsAlgAss.jl 91.54% <100.00%> (ø)
src/AlgAss/AlgAss.jl 87.89% <100.00%> (ø)
src/AlgAss/ChangeRing.jl 92.37% <100.00%> (ø)
src/AlgAss/Map.jl 77.50% <ø> (ø)
src/AlgAssAbsOrd/FakeAbsOrdQuoRing.jl 100.00% <100.00%> (ø)
src/AlgAssAbsOrd/Ideal.jl 74.31% <100.00%> (-0.09%) ⬇️
src/Deprecations.jl 100.00% <ø> (ø)
src/EllCrv/EllCrv.jl 95.95% <ø> (ø)
src/EllCrv/Finite.jl 94.10% <100.00%> (ø)
src/EllCrv/Pairings.jl 92.63% <100.00%> (-1.06%) ⬇️
... and 85 more

... and 18 files with indirect coverage changes

@thofma thofma enabled auto-merge (squash) January 26, 2024 08:09
@thofma thofma merged commit 82355e3 into thofma:master Jan 26, 2024
15 checks passed
@lgoettgens lgoettgens deleted the lg/nemo-bump branch January 26, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants