Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some trailing newlines from show methods #1363

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

lgoettgens
Copy link
Contributor

@lgoettgens lgoettgens commented Jan 24, 2024

This makes the types print nicer in e.g. a vector (similar to #1350)

Copy link
Contributor

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Merging #1363 (258e04e) into master (32f4359) will increase coverage by 64.73%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1363       +/-   ##
===========================================
+ Coverage    5.55%   70.28%   +64.73%     
===========================================
  Files         351      351               
  Lines      111675   111825      +150     
===========================================
+ Hits         6207    78600    +72393     
+ Misses     105468    33225    -72243     
Files Coverage Δ
src/Misc/Integer.jl 49.42% <ø> (+42.02%) ⬆️
src/NumFieldOrd/NfOrd/Ideal/Ideal.jl 82.75% <ø> (+64.97%) ⬆️
src/AlgAssAbsOrd/Ideal.jl 74.31% <0.00%> (+74.31%) ⬆️
src/Grp/GenGrp.jl 69.38% <0.00%> (+69.38%) ⬆️
src/GrpAb/Lattice.jl 84.89% <0.00%> (+84.89%) ⬆️
src/NumFieldOrd/NfOrd/Unit/UnitGrpCtx.jl 69.26% <0.00%> (+11.68%) ⬆️
src/Sparse/Module.jl 74.57% <0.00%> (ø)

... and 288 files with indirect coverage changes

@thofma thofma enabled auto-merge (squash) January 24, 2024 21:21
@thofma thofma merged commit b2472e9 into thofma:master Jan 24, 2024
18 checks passed
@lgoettgens lgoettgens deleted the lg/show-newline branch January 25, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants