Add Base.conj
for AbsSimpleNumFieldElem
#1622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @fieker, @lgoettgens and @joschmitt on Friday at the OSCAR workshop I've added a
Base.conj
method forAbsSimpleNumFieldElem
. The main purpose of this is to provide an easy way to conjugate cyclotomic numbers interactively (for actual implementationscomplex_conjugation
should be better). After looking at the code I'm not sure why checking the parent field should be necessary. I think we can leave all the checks tocomplex_conjugation
.