Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge RealNumberField #1694

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

fingolfin
Copy link
Contributor

Resolves #979

Of course this is a breaking change

@fingolfin fingolfin force-pushed the mh/purge-RealNumberField branch from 8f3a517 to e5415d0 Compare November 28, 2024 23:18
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.39%. Comparing base (5d2ba17) to head (e5415d0).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1694      +/-   ##
==========================================
+ Coverage   75.93%   76.39%   +0.46%     
==========================================
  Files         362      361       -1     
  Lines      114328   118047    +3719     
==========================================
+ Hits        86812    90180    +3368     
- Misses      27516    27867     +351     
Files with missing lines Coverage Δ
src/Hecke.jl 46.13% <ø> (-5.15%) ⬇️

... and 50 files with indirect coverage changes

@thofma thofma closed this Dec 15, 2024
@thofma thofma reopened this Dec 15, 2024
@thofma thofma merged commit 3429dd8 into thofma:master Dec 16, 2024
32 checks passed
@fingolfin fingolfin deleted the mh/purge-RealNumberField branch December 16, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purge RealNumberField(Elem)
2 participants