Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update lru to v0.12.5 #118

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

Adamska1008
Copy link
Contributor

@Adamska1008 Adamska1008 commented Dec 4, 2024

fix #117

Description

Fixes #117 by update lru to v0.12.5 with cargo update -p lru which modify the cargo.lock only.

How Has This Been Tested?

Run cargo test, output:

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/main.rs (target/debug/deps/chess_tui-ea589f1ba1887773)

running 1 test
test tests::test_config_create ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/checkmates.rs (target/debug/deps/checkmates-f303a0df9e70e4b6)

running 7 tests
test tests::is_checkmate_false ... ok
test tests::is_checkmate_true ... ok
test tests::is_getting_checked_false ... ok
test tests::is_getting_checked_piece_in_front_false ... ok
test tests::is_getting_checked_piece_in_with_gap_false ... ok
test tests::is_getting_checked_true ... ok
test tests::is_checkmate_false_2 ... ok

test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/draws.rs (target/debug/deps/draws-baa0ea82166b69c8)

running 4 tests
test tests::fifty_moves_draw ... ok
test tests::is_draw_false ... ok
test tests::is_draw_true ... ok
test tests::consecutive_position_draw ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/fen.rs (target/debug/deps/fen-36bd3ddb6f3bff71)

running 3 tests
test tests::fen_converter_1 ... ok
test tests::fen_converter_castling ... ok
test tests::fen_converter_en_passant ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/lib.rs (target/debug/deps/lib-217d4e42beaedcf4)

running 45 tests
test pieces::bishop::tests::king_checked_cant_resolve ... ok
test pieces::bishop::tests::king_checked_can_resolve ... ok
test pieces::bishop::tests::piece_move_multiple_enemies_and_ally_front ... ok
test pieces::bishop::tests::nailing ... ok
test pieces::king::tests::big_castle_black ... ok
test pieces::bishop::tests::piece_move_no_enemies ... ok
test pieces::king::tests::big_castle_black_check_blocking ... ok
test pieces::bishop::tests::piece_move_one_enemies_top_right ... ok
test pieces::king::tests::big_castle_black_king_checked ... ok
test pieces::king::tests::big_castle_black_rook_already_moved ... ok
test pieces::king::tests::big_castle_white ... ok
test pieces::king::tests::castle_both_sides ... ok
test pieces::king::tests::multiple_enemies_1 ... ok
test pieces::king::tests::multiple_enemies_2 ... ok
test pieces::king::tests::small_castle_black ... ok
test pieces::king::tests::multiple_enemies_3 ... ok
test pieces::king::tests::small_castle_white ... ok
test pieces::knight::tests::enemy_and_ally ... ok
test pieces::knight::tests::king_checked_can_resolve ... ok
test pieces::knight::tests::king_checked_cant_resolve ... ok
test pieces::knight::tests::no_enemies ... ok
test pieces::knight::tests::nailing ... ok
test pieces::pawn::tests::king_checked_can_resolve ... ok
test pieces::pawn::tests::king_checked_cant_resolve ... ok
test pieces::pawn::tests::nailing ... ok
test pieces::pawn::tests::pawn_en_passant_black ... ok
test pieces::pawn::tests::pawn_en_passant_white ... ok
test pieces::pawn::tests::pawn_not_en_passant ... ok
test pieces::pawn::tests::piece_move_3_enemies_one_pawn ... ok
test pieces::pawn::tests::piece_move_one_cell_enemy_left_right ... ok
test pieces::pawn::tests::piece_move_one_cell_forward ... ok
test pieces::pawn::tests::piece_move_one_cell_forward_two ... ok
test pieces::pawn::tests::piece_move_one_pawn_3_enemies ... ok
test pieces::queen::tests::king_checked_can_resolve ... ok
test pieces::queen::tests::king_checked_cant_resolve ... ok
test pieces::queen::tests::piece_move_enemies_and_allies ... ok
test pieces::queen::tests::nailing ... ok
test pieces::rook::tests::king_checked_can_resolve ... ok
test pieces::rook::tests::piece_move_multiple_enemies_and_ally_front ... ok
test pieces::queen::tests::piece_move_no_enemies ... ok
test pieces::rook::tests::king_checked_cant_resolve ... ok
test pieces::rook::tests::nailing ... ok
test pieces::rook::tests::piece_move_no_enemies ... ok
test pieces::queen::tests::piece_move_one_enemies_top_right ... ok
test pieces::rook::tests::piece_move_one_enemies_front ... ok

test result: ok. 45 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/promotions.rs (target/debug/deps/promotions-2576e32ba0f13525)

running 5 tests
test tests::is_promote_false ... ok
test tests::is_promote_true ... ok
test tests::is_promote_true_black ... ok
test tests::promote_and_draw ... ok
test tests::promote_and_checkmate ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/utils.rs (target/debug/deps/utils-b85fee676064e25d)

running 5 tests
test tests::convert_notation_into_position_1 ... ok
test tests::convert_notation_into_position_2 ... ok
test tests::convert_notation_into_position_3 ... ok
test tests::convert_position_into_notation_1 ... ok
test tests::convert_position_into_notation_2 ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chess_tui

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Checklist:

(no code changed so seems all unrelevant)

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules (not sure what's this)

@Adamska1008
Copy link
Contributor Author

Not sure if I should modify the comment myself. I will leave it to maintainer.

Checking chess-tui v1.5.0 (/home/runner/work/chess-tui/chess-tui)
error: empty line after doc comment
   --> src/game_logic/ui.rs:110:5
    |
110 | /     /// CURSOR MOVEMENT
111 | |
    | |_
112 |       /// Move the cursor up
113 |       pub fn cursor_up(&mut self, authorized_positions: Vec<Coord>) {
    |       ------------------------------------------------------------- the comment documents this method
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
    = note: `-D clippy::empty-line-after-doc-comments` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::empty_line_after_doc_comments)]`
    = help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
    |
111 |     ///
    |

error: could not compile `chess-tui` (lib) due to 1 previous error

@thomas-mauran
Copy link
Owner

Thank you for the contribution 🎉 !

Not sure if I should modify the comment myself. I will leave it to maintainer.

Yeah seems like the CI is not happy with a comment I fixed it

@thomas-mauran thomas-mauran merged commit 5a7adcf into thomas-mauran:main Dec 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build with latest nightly rustc.
2 participants