Wait until hass initialized before merging card and theme styles #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # card-mod.js # package-lock.json
thomasloven
reviewed
Nov 22, 2023
src/helpers.ts
Outdated
| @@ -168,9 +173,9 @@ export function getResources() { | |||
| const retval = []; | |||
| for (const script of scriptElements) { | |||
| if (script?.innerText?.trim()?.startsWith("import(")) { | |||
| const imports = script.innerText.split("\n")?.map((e) => e.trim()); | |||
| const imports = script.innerText.split(/[\n;]/)?.map((e) => e.trim()).filter(e => e); | |||
There was a problem hiding this comment.
Hi, yes, you are correct. This was a one-liner fix that was later implemented in #278 and is not needed here. I pushed another commit reverting this change.
Unfortunately this does not work for me. I do not experience this behaviour with card-embedded styles; my beef is with global styles that are defined in custom Home Assistant theme. Here - in my case - the problem is the missing value of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request may fix issues described in #152 (in some cases).
I experienced similar behavior - styles not being applied after page refresh - on one of my dashboards. I suspect some race condition occurs when
card-modstyles are being applied as styles are correctly applied on some of my dashboards and randomly on others.Please note that I am using a custom
card-modtheme and the missing styles are set globally in the theme.I noticed that sometimes
card-moddid not read value of CSS variable--card-mod-themecorrectly when debugging the issue. Movingawait hass()in front ofgetPropertyValue("--card-mod-theme")appears to block the app for just enough time that variable--card-mod-themeis being set and can be read bycard-mod.It is quite possible that this is not a definite fix for #152.
await hass()call postpones variable read for a few ticks and this may suffice in my particular case - refreshing page now works in 100% of my cases. YMMV.