Skip to content

Commit

Permalink
Chore/fix workflow sha (#807)
Browse files Browse the repository at this point in the history
* checkout merge commit of PR, not base branch head

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

* use link to test result, gif exceeds github allowed content length
  • Loading branch information
bj00rn authored Jun 1, 2024
1 parent 20a3202 commit 3229ef5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ jobs:
options: --user root
steps:
- uses: actions/checkout@v4
with:
ref: '${{ github.event.pull_request.merge_commit_sha }}' # since event is pull_request_target
- name: Install Packages
run: yarn install --frozen-lockfile
- name: Build
Expand All @@ -35,4 +37,4 @@ jobs:
- name: Show URL
run: echo '${{ steps.upload.outputs.file-url }}'
id: artifact-upload-step
- run: echo '![test](${{ steps.upload.outputs.file-url }})' >> $GITHUB_STEP_SUMMARY
- run: echo '<picture><img src="${{ steps.upload.outputs.file-url }}"></picture>' >> $GITHUB_STEP_SUMMARY

0 comments on commit 3229ef5

Please sign in to comment.