Skip to content

Commit

Permalink
run revdepcheck
Browse files Browse the repository at this point in the history
  • Loading branch information
thomasp85 committed Feb 27, 2024
1 parent aff909b commit 3d0c678
Show file tree
Hide file tree
Showing 5 changed files with 37 additions and 121 deletions.
9 changes: 3 additions & 6 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,15 @@ have been contacted and have prepared a fix

## revdepcheck results

We checked 81 reverse dependencies (80 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
We checked 93 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 2 new problems
* We saw 1 new problems
* We failed to check 0 packages

Issues with CRAN packages are summarised below.

### New problems
(This reports the first line of each new failure)

* LabApplStat
checking examples ... ERROR

* migraph
* ggdag
checking tests ... ERROR
15 changes: 4 additions & 11 deletions revdep/README.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,8 @@
# Revdeps

## Failed to check (1)
## New problems (1)

|package |version |error |warning |note |
|:-------|:-------|:-----|:-------|:----|
|NA |? | | | |

## New problems (2)

|package |version |error |warning |note |
|:--------------------------------------|:-------|:------|:-------|:----|
|[LabApplStat](problems.md#labapplstat) |1.4.3 |__+1__ | | |
|[migraph](problems.md#migraph) |0.12.0 |__+1__ | |1 |
|package |version |error |warning |note |
|:-------|:-------|:------|:-------|:----|
|[ggdag](problems.md#ggdag)|0.2.11 |__+1__ | |1 |

9 changes: 3 additions & 6 deletions revdep/cran.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
## revdepcheck results

We checked 81 reverse dependencies (80 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
We checked 93 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 2 new problems
* We saw 1 new problems
* We failed to check 0 packages

Issues with CRAN packages are summarised below.

### New problems
(This reports the first line of each new failure)

* LabApplStat
checking examples ... ERROR

* migraph
* ggdag
checking tests ... ERROR

36 changes: 1 addition & 35 deletions revdep/failures.md
Original file line number Diff line number Diff line change
@@ -1,35 +1 @@
# NA

<details>

* Version: NA
* GitHub: NA
* Source code: https://github.com/cran/NA
* Number of recursive dependencies: 0

Run `cloud_details(, "NA")` for more info

</details>

## Error before installation

### Devel

```
```
### CRAN

```
```
*Wow, no problems at all. :)*
89 changes: 26 additions & 63 deletions revdep/problems.md
Original file line number Diff line number Diff line change
@@ -1,78 +1,40 @@
# LabApplStat
# ggdag

<details>

* Version: 1.4.3
* GitHub: NA
* Source code: https://github.com/cran/LabApplStat
* Date/Publication: 2021-11-29 09:40:06 UTC
* Number of recursive dependencies: 123
* Version: 0.2.11
* GitHub: https://github.com/r-causal/ggdag
* Source code: https://github.com/cran/ggdag
* Date/Publication: 2024-01-24 15:30:05 UTC
* Number of recursive dependencies: 103

Run `cloud_details(, "LabApplStat")` for more info

</details>

## Newly broken

* checking examples ... ERROR
```
Running examples in ‘LabApplStat-Ex.R’ failed
The error most likely occurred in:
> ### Name: DD
> ### Title: Design diagram for a linear model
> ### Aliases: DD
> ### Keywords: design manip
>
> ### ** Examples
>
...
>
> #Making the factor diagram closed under minima
> mydata <- data.frame(age=rep(c("boy","girl","adult","adult"),4),
+ gender=rep(c("child","child","man","woman"),4))
> myDD <- DD(~0+age+gender,data=mydata)
> plot(myDD)
Error in unit(attr(ggraph::label_rect(text0, fontsize = 18), "width"), :
'x' and 'units' must have length > 0
Calls: <Anonymous> ... <Anonymous> -> convertUnit -> upgradeUnit -> is.newUnit -> unit
Execution halted
```
# migraph
<details>
* Version: 0.12.0
* GitHub: https://github.com/snlab-ch/migraph
* Source code: https://github.com/cran/migraph
* Date/Publication: 2022-09-27 07:50:02 UTC
* Number of recursive dependencies: 131
Run `cloud_details(, "migraph")` for more info
Run `revdepcheck::cloud_details(, "ggdag")` for more info

</details>

## Newly broken

* checking tests ... ERROR
```
Running ‘spelling.R’
Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
3. │ └─rlang::eval_bare(expr, quo_get_env(quo))
4. ├─base::as.character(test_networkers[["layers"]][[2]][["aes_params"]][["end_cap"]])
5. └─vctrs:::as.character.vctrs_vctr(test_networkers[["layers"]][[2]][["aes_params"]][["end_cap"]])
6. └─vctrs::vec_cast(x, character())
7. └─vctrs (local) `<fn>`()
8. └─vctrs::vec_default_cast(...)
9. └─vctrs::stop_incompatible_cast(...)
10. └─vctrs::stop_incompatible_type(...)
11. └─vctrs:::stop_incompatible(...)
12. └─vctrs:::stop_vctrs(...)
13. └─rlang::abort(message, class = c(class, "vctrs_error"), ..., call = vctrs_error_call(call))
Complete output:
> library(testthat)
> library(ggdag)
Attaching package: 'ggdag'
[ FAIL 2 | WARN 0 | SKIP 0 | PASS 520 ]
The following object is masked from 'package:stats':
...
• quick_plots/ggdag-collider-triangle-is-triangle-too.svg
• quick_plots/ggdag-confounder-triangle-is-triangle.svg
• relations/ggdag-ancestors-identifies-v-w1-and-z1.svg
• relations/ggdag-descendants-identifies-y-x-and-z1.svg
• relations/ggdag-parents-identifies-z2-x-w1-and-w2.svg
• themes/theme-dag-gray-grid.svg
• themes/theme-dag-gray.svg
• themes/theme-dag-grid.svg
Error: Test failures
Execution halted
```
Expand All @@ -81,8 +43,9 @@ Run `cloud_details(, "migraph")` for more info
* checking installed package size ... NOTE
```
installed size is 5.1Mb
installed size is 8.2Mb
sub-directories of 1Mb or more:
doc 3.0Mb
doc 6.6Mb
help 1.1Mb
```

0 comments on commit 3d0c678

Please sign in to comment.