Skip to content

Improvements in data structure (keywords and image added) and corrections in href logic #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
morissonmaciel wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improvements in data structure (keywords and image added) and corrections in href logic #12

morissonmaciel wants to merge 5 commits into from

Conversation

@morissonmaciel
Copy link

@morissonmaciel morissonmaciel commented Nov 10, 2018

Hello, @thomastuts,
I make some changes in article-extractor to improve de data structure returned from its main extractArticle function.

First I included two new attributes:

  1. keywords
    Obtained from tags related to "keywords" name and "swiftype > keys" variant (common used in most articles in internet (see. Engadget.com and all Vox Media articles pages)

  2. image
    Obtained from two sources: a scored rank from all <img> from <body> or <main> section.; otherwise from tags related to "swiftype > image" variant.

Also, make changes in obtaining author data using tags related to "swiftype > blogger_name" variant.

Note: author image can be obtained from blogger_image and may be pushed to a new metadata property in future improvement.

The documentation was slightly improved with these new fields and a increment in minor version was made: 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@morissonmaciel