Inform user when rip offset is not saved when running 'rip offset find'#93
Open
Gachapen wants to merge 1 commit intothomasvs:masterfrom
Open
Inform user when rip offset is not saved when running 'rip offset find'#93Gachapen wants to merge 1 commit intothomasvs:masterfrom
Gachapen wants to merge 1 commit intothomasvs:masterfrom
Conversation
Contributor
|
Looks good to me. 👍 |
Contributor
|
I think this one can now be closed (this behaviour was fixed with the last merged pull request: #138). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This confused me when finding the offset for my drive. I thought the offset was saved as no message was displayed, but no configuration file was present. I had to go through the source code to find out why. I think this message will help users in this scenario.