52 displayparagraphif doesnt work inside table with repeattablerow master javax #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated docx-stamper pom
added hierarchy to comments
* added ability to replace unresolved placeholders with a global default value * fixed repeatDocPart cases when no data given * added a displayParagraphIfPresent comment processor
* add github actions for helping with maintenance * remove gradle reference Co-authored-by: Joseph Verron <joseph.verron@totalenergies.com>
Bumps [junit](https://github.com/junit-team/junit4) from 4.4 to 4.13.2. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.2.md) - [Commits](https://github.com/junit-team/junit4/commits/r4.13.2) --- updated-dependencies: - dependency-name: junit:junit dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps commons-io from 2.5 to 2.11.0. --- updated-dependencies: - dependency-name: commons-io:commons-io dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [spring-expression](https://github.com/spring-projects/spring-framework) from 4.3.6.RELEASE to 5.3.22. - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v4.3.6.RELEASE...v5.3.22) --- updated-dependencies: - dependency-name: org.springframework:spring-expression dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* added resilience to null values in repeating processors * added behaviors for replace null values option in comment processors * added deprecation notice on replaceWith comment processor
* Improve maven test run setup * Remove gradle reference * add maven site setup * add pitest mutation testing * update scm url Co-authored-by: Joseph Verron <joseph.verron@totalenergies.com>
Bumps [pitest-maven](https://github.com/hcoles/pitest) from 1.7.2 to 1.9.5. - [Release notes](https://github.com/hcoles/pitest/releases) - [Commits](hcoles/pitest@1.7.2...1.9.5) --- updated-dependencies: - dependency-name: org.pitest:pitest-maven dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.3.0 to 3.4.1. - [Release notes](https://github.com/apache/maven-project-info-reports-plugin/releases) - [Commits](apache/maven-project-info-reports-plugin@maven-project-info-reports-plugin-3.3.0...maven-project-info-reports-plugin-3.4.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-project-info-reports-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [maven-resources-plugin](https://github.com/apache/maven-resources-plugin) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/apache/maven-resources-plugin/releases) - [Commits](apache/maven-resources-plugin@maven-resources-plugin-3.2.0...maven-resources-plugin-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-resources-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.0.0-M5 to 3.0.0-M7. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.0.0-M5...surefire-3.0.0-M7) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [javassist](https://github.com/jboss-javassist/javassist) from 3.21.0-GA to 3.29.1-GA. - [Release notes](https://github.com/jboss-javassist/javassist/releases) - [Changelog](https://github.com/jboss-javassist/javassist/blob/master/Changes.md) - [Commits](https://github.com/jboss-javassist/javassist/commits) --- updated-dependencies: - dependency-name: org.javassist:javassist dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ointerException later (#25) * skipping malformed comments in CommentUtil.getComments to avoid NullPointerException later * bump version
Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.3.1 to 3.4.1. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.3.1...maven-javadoc-plugin-3.4.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-javadoc-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [maven-surefire-report-plugin](https://github.com/apache/maven-surefire) from 3.0.0-M5 to 3.0.0-M7. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.0.0-M5...surefire-3.0.0-M7) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-report-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [spring-expression](https://github.com/spring-projects/spring-framework) from 5.3.22 to 5.3.23. - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v5.3.22...v5.3.23) --- updated-dependencies: - dependency-name: org.springframework:spring-expression dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.9.1 to 3.12.1. - [Release notes](https://github.com/apache/maven-site-plugin/releases) - [Commits](apache/maven-site-plugin@maven-site-plugin-3.9.1...maven-site-plugin-3.12.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-site-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [javassist](https://github.com/jboss-javassist/javassist) from 3.29.1-GA to 3.29.2-GA. - [Release notes](https://github.com/jboss-javassist/javassist/releases) - [Changelog](https://github.com/jboss-javassist/javassist/blob/master/Changes.md) - [Commits](https://github.com/jboss-javassist/javassist/commits) --- updated-dependencies: - dependency-name: org.javassist:javassist dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* rework generated doc part to import images the right way (wip) * import images data in the final doc before adding content from the generated doc part sub documents * prepare next snapshot for testing Co-authored-by: Youssouf Naciri <youssouf.naciri@external.totalenergies.com>
Co-authored-by: Joseph Verron <joseph.verron@totalenergies.com>
Co-authored-by: Youssouf Naciri <youssouf.naciri@external.totalenergies.com>
Co-authored-by: Thomas Oster <t.oster@landcode.de>
* working on a test for #109 * fixed configuration attribute FailOnUnresolvedExpression ignored by ParagraphRepeatProcessor * removed proxy utilization in favor of MethodResolver and MethodExecutor unified reading configuration from different classes instead of copying them * extracted MethodExecutor from MethodResolver for fine tuning according to runtime configuration renamed CommentProcessorMethodResolver.java since it resolves expression context methods too * removed unused configuration from DisplayIfProcessor fixed StandardMethodResolver when method arguments resolve to null value to make it match any type * removed writing docx result to disk in favor of assertions in unit test Co-authored-by: Youssouf Naciri <ynaciri@gmail.com>
BREAKING CHANGE * changed the way of adding comment processors, users give interfaces and class, not instances * all comment processors have the same constructor signature NEW FEATURE * added TableResolver to the standard list of resolvers * added documentation in the README for resolveTable processor NON-BREAKING CHANGE * fixed image bug and corresponding unit test in repeatDocPart * renamed some utility methods and make them public * changed exception messages in comment gathering to make errors more readable * added missing use cases in DocumentWalker (run at Tc level was ignored by it) * added a setDocument method on comment processor so that they can access the StoreParts * harmonize comments removal over all comments processors * fixed some bugs in RepeatDocPartProcessor detection of bounds for the part to repeat * fixed issue with comment range removal for repeatDocPart * fixed issue with comment range references removal for Tr copies for repeatTableRow * fixed issue with comment range references removal for P copies for repeatParagraph * added copy method on DocxStamperConfiguration * added DocxStamperConfiguration copy method for repeatDocPart * removed comment anchors from copied paragraphs in ParagraphRepeatProcessor * added a test case mixing repeatDocPart with repeatTableRow to ensure comment processor instances isolation
ynaciri
deleted the
52-displayparagraphif-doesnt-work-inside-table-with-repeattablerow-master-javax
branch
ynaciri
restored the
52-displayparagraphif-doesnt-work-inside-table-with-repeattablerow-master-javax
branch
caring-coder
deleted the
52-displayparagraphif-doesnt-work-inside-table-with-repeattablerow-master-javax
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported @NoNException PR for issue #92 (see #100)