Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paragraph deletion index shifts after repeatDocPart #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix paragraph deletion index shifts after repeatDocPart #84

wants to merge 1 commit into from

Conversation

postpersonality
Copy link

It's a monkey-patch for ObjectDeleter.deleteParagraph() which fixes index shifts after repeatDocPart processor.

@thombergs
Copy link
Owner

Sorry to revive this after so long a time, but can you explain the issue you were facing that triggered this fix (and potentially add a unit test)?

@postpersonality
Copy link
Author

Well, I don't remember exactly, but reading the code it solves the case when indexToDelete becomes incorrect and we need to revalidate it. Maybe (I do not remember) it' because we had repeat block before the deletion block. Yeah, if I had a unit-test the reason for the change would be clear. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@postpersonality @thombergs